-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make it clear that the user needs to deal with NServiceBus messages in addition to native messages #6924
base: master
Are you sure you want to change the base?
Conversation
…n addition to native messages
@@ -0,0 +1,15 @@ | |||
### Custom envelope unwrapper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be the same as the paragraph above or am I not seeing the difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one less sentence in the warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it now - wouldn't it be the same in both though it we are backporting the change?
I'm not sure on the structure of the snippet/sample. Shouldn't it be something more like (pseudocode)
or
I'm concerned about the focus on checking for base64 (an internal implementation detail) rather than making it clear that if the message can't be handled by the custom unwrapper, then null should be returned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I didn't mean to approve this PR
related to Particular/NServiceBus.AzureStorageQueues#1264